Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #14157 #15877

Merged
merged 7 commits into from
Nov 12, 2020
Merged

fix #14157 #15877

merged 7 commits into from
Nov 12, 2020

Conversation

ringabout
Copy link
Member

No description provided.

Araq
Araq reviewed Nov 9, 2020
View reviewed changes
compiler/jsgen.nim Outdated Show resolved Hide resolved
@juancarlospaco
Copy link
Collaborator

Should it have a line on the changelog?. 🤔

@timotheecour
Copy link
Member

timotheecour commented Nov 10, 2020 •
edited
Loading

where is []= even defined for cstring ? I commented out a few suspects but it doesn't give CT error (would seem cleaner to disable it by patching the relevant []= proc, but not sure how to do that); #15911 also makes it hard (from system import nil doesn't help with disabling []=).

I'm guessing []= is treated specially for string/cstring in the compiler, but is there a reason to?

@ringabout
Copy link
Member Author

I'm confused too. That's the reason why I choose to change JS gen.
#14157 (comment)

@timotheecour timotheecour mentioned this pull request Nov 11, 2020
Open
Araq
Araq approved these changes Nov 12, 2020
View reviewed changes
compiler/jsgen.nim Outdated Show resolved Hide resolved
tests/js/tmodify_cstring.nim Outdated Show resolved Hide resolved
@Araq Araq merged commit 1f9bf43 into nim-lang:devel Nov 12, 2020
narimiran pushed a commit that referenced this pull request Nov 16, 2020
@ringabout @narimiran
fix #14157 (#15877)
23b0b10 
* fix #14157

* Update compiler/jsgen.nim

* add changelog

* Update compiler/jsgen.nim

* Update tests/js/tmodify_cstring.nim

Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
(cherry picked from commit 1f9bf43)
PMunch pushed a commit to PMunch/Nim that referenced this pull request Jan 6, 2021
@ringabout @Araq @PMunch
fix nim-lang#14157 (nim-lang#15877)
70dca4d 
* fix nim-lang#14157

* Update compiler/jsgen.nim

* add changelog

* Update compiler/jsgen.nim

* Update tests/js/tmodify_cstring.nim

Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
@ringabout @Araq @mildred
fix nim-lang#14157 (nim-lang#15877)
3ef667a 
* fix nim-lang#14157

* Update compiler/jsgen.nim

* add changelog

* Update compiler/jsgen.nim

* Update tests/js/tmodify_cstring.nim

Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
@timotheecour timotheecour mentioned this pull request Feb 1, 2021
Open
irdassis pushed a commit to irdassis/Nim that referenced this pull request Mar 16, 2021
@ringabout @Araq @irdassis
fix nim-lang#14157 (nim-lang#15877)
e55d6a3 
* fix nim-lang#14157

* Update compiler/jsgen.nim

* add changelog

* Update compiler/jsgen.nim

* Update tests/js/tmodify_cstring.nim

Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
@ringabout @Araq @ardek66
fix nim-lang#14157 (nim-lang#15877)
91c280f 
* fix nim-lang#14157

* Update compiler/jsgen.nim

* add changelog

* Update compiler/jsgen.nim

* Update tests/js/tmodify_cstring.nim

Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Araq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ringabout @juancarlospaco @timotheecour @Araq